1. Topics
  2. Licence scanning

Licence scanning

TILLOY Anne
 

Hi TSC member,

 

Here are the results of the license scanning performed by the LFE: https://lfscanning.org/reports/lfenergy/powsybl-2021-04-20-ed46eeb7-b4a3-4f66-8266-e757e3fb0c46.xlsx

 

We miss some license headers and sometimes the author is missing too. I have fixed the powsybl-core java files, using the year of the first commit for the copyright. I am going to fix also the tutorials and the powsybl-open-loadflow repository. It remains the underlying files. Please open a PR on each repository with the changes requested. Note that this email only focus on Java source file.

 

Note that a preventive strategy could be to use the check REUSE https://github.com/marketplace/actions/reuse-compliance-check Who is volunteer to help on that subject if you all agree?

 

Thanks a lot.

 

Anne.

 

powsybl-gse/gse-network-map/src/main/test/com/powsybl/gse/map/DataTest

java

powsybl-core/loadflow/loadflow-api/src/test/java/com/powsybl/loadflow/json/JsonLoadFlowParametersTest

java

powsybl-core/iidm/iidm-impl/src/test/java/com/powsybl/iidm/network/impl/TapChangerAttributeTest

java

powsybl-core/security-analysis-api/src/test/java/com/powsybl/security/SecurityAnalysisResultBuilderTest

java

powsybl-core/security-analysis-api/src/test/java/com/powsybl/security/json/JsonSecurityAnalysisParametersTest

java

powsybl-core/cgmes/cgmes-model/src/test/java/com/powsybl/cgmes/model/test/FakeCgmesModel

java

powsybl-core/triple-store/triple-store-test/src/test/java/com/powsybl/triplestore/test/QueryCatalogTest

java

powsybl-core/entsoe-util/src/test/java/com/powsybl/entsoe/util/MergedXnodeXmlSerializerTest

java

powsybl-core/entsoe-util/src/test/java/com/powsybl/entsoe/util/EntsoeAreaXmlSerializerTest

java

powsybl-core/entsoe-util/src/test/java/com/powsybl/entsoe/util/XnodeXmlSerializerTest

java

powsybl-core/math/src/test/java/com/powsybl/math/graph/GraphUtilTest

java

powsybl-core/math/src/main/java/com/powsybl/math/matrix/package-info

java

powsybl-core/computation/src/test/java/com/powsybl/computation/CompletableFutureTaskTest

java

powsybl-core/time-series/time-series-api/src/test/java/com/powsybl/timeseries/ReadOnlyTimeSeriesStoreAggregatorTest

java

powsybl-core/action/action-dsl/src/main/java/com/powsybl/action/dsl/RuleType

java

powsybl-hpc/computation-mpi/src/main/java/com/powsybl/computation/mpi/generated/Messages

java

powsybl-network-store/network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/VoltageLevelUtil

java

powsybl-network-store/network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/SubstationUtil

java

powsybl-network-store/network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreApplication

java

powsybl-tutorials/loadflow/initial/src/main/java/powsybl/tutorials/loadflow/LoadFlowTutorial

java

powsybl-tutorials/sensitivity/initial/src/main/java/powsybl/tutorials/sensitivity/SensitivityTutorial

java

powsybl-open-loadflow/src/test/java/com/powsybl/openloadflow/network/NodeBreakerNetworkFactory

java

powsybl-afs/afs-spring-server/src/test/java/com/powsybl/afs/server/AppDataWrapperTest

java

powsybl-afs/afs-core/src/main/java/com/powsybl/afs/package-info

java

 

 

logo

Anne TILLOY
PES/DSIT/DDL
Immeuble window - 7c place du dome
92800 Paris la defense
T+33 (0)1 41 02 15 32 – P+33 (0)6 46 16 22 39

 

 



"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.

This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."

JAMGOTCHIAN Geoffroy
 

Hi,

For powsybl-hpc/computation-mpi/src/main/java/com/powsybl/computation/mpi/generated/Messages this is a generated file so maybe we should configure the scanner to exclude it. It does not make sense (or maybe is illegal?) to add a licence/authorship to a generated file.

For the preventive strategy, I would go for a Maven plugin instead because we can test it locally before pushing the code (same kind of check as checkstyle).
Indeed it will only check Java files but that is 99% of our files (powsybl cpp excluded)

Geoffroy
BAGUE Mathieu
 

Hi,

I don't know if it's easily feasable, but generated source files should be in the target/generated-classes. If I remember well, we decided to commit it to reduce compilation time. Could it make sense to remove this file from the repo and generate it from the protobuf IDL file in the target directory?

Best,
Mathieu

Le mardi 27 avril 2021 à 07:50 -0700, JAMGOTCHIAN Geoffroy via lists.lfenergy.org a écrit :
EXPÉDITEUR EXTERNE: Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe à moins qu’ils ne proviennent d’un expéditeur fiable, ou que vous ayez l'assurance que le contenu provient d'une source sûre.

Hi,

For powsybl-hpc/computation-mpi/src/main/java/com/powsybl/computation/mpi/generated/Messages this is a generated file so maybe we should configure the scanner to exclude it. It does not make sense (or maybe is illegal?) to add a licence/authorship to a generated file.

For the preventive strategy, I would go for a Maven plugin instead because we can test it locally before pushing the code (same kind of check as checkstyle).
Indeed it will only check Java files but that is 99% of our files (powsybl cpp excluded)

Geoffroy


"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.

This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."

JAMGOTCHIAN Geoffroy
 
Edited

Not easy because we need protobuf compiler which is platform dependent, so it means powsybl-hpc would be painful to build.
1 - 4 of 4