Topics

Call for vote: disable sonarsource violation squid:S3725 (a.k.a Java8's poor performance on Files.Exists())

HARPER Jon
 
Edited

Hi list,

we have 46 violations of squid:S3725

https://sonarcloud.io/project/issues?id=com.powsybl%3Apowsybl-core&resolved=false&rules=squid%3AS3725

 

However, as verbally confirmed by mathbagu and geofjamg, this rule assumes that only the default filesystem (returned by Filesystems.getDefault() ) is used. For other filesystem, it is not possible to use the rule's replacement (path.toFile().exists() ).

 

Since we do use other Filesystems, I propose that we disable this rule for our project.

I vote for disabling the squid:S3725 rule

 

Cheers,
Jon



"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.

This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."

Luis María Zamarreño García
 

On Thu, Sep 12, 2019 at 12:21 PM, HARPER Jon wrote:
I vote for disabling the squid:S3725 rule
You have my vote for disabling the rule squid:S3725
Should we use the "poll" tool from the distribution list?

BAGUE Mathieu
 

I agree to disable this rule too.

If we decide to disable it, we have to create a file that explains which rules are disabled and the reason why.

MURGEY Sebastien
 

I also vote in favor of this proposition.

Sébastien